Add Codemirror search functionality (#219, #629) #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komediruzecki
force-pushed
the
feature/add-search-and-replace-in-editor
branch
2 times, most recently
from
fcdad9d to
763040f
Compare
Update Codemirror to latest Update Codemirror typings to latest Add code mirror search functionality (include needed addons) Add some styling of replace search buttons by adding css to StyledContainer in CodeEditordd Add extraKeys: esc when search dialog found something and marked it - to clear the serach contents (without need of calling the serach again) Add extraKeys: Alt+F - persistant find/search to have dialog persistent while searching
Komediruzecki
force-pushed
the
feature/add-search-and-replace-in-editor
branch
from
763040f to
c66f197
Compare
Komediruzecki
changed the title
Komediruzecki
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Codemirror search functionality (c66f197) (#219, #629)
Update Codemirror to latest
Update Codemirror typings to latest
Add code mirror search functionality (include needed addons)
Add some styling of replace search buttons by adding css to StyledContainer in CodeEditor
Add extraKeys: esc when search dialog found something and marked it - to clear the serach contents (without need of calling the serach again)
Add extraKeys: Alt+F - persistant find/search to have dialog persistent while searching
Test:
In electron Linux App (dev)
In electron Linux App production version (appImage)
Todo:
- An option to select, so it only searches titles of notes, instead of contents and notes simultaneously.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: